Shovels: start local shovels with predeclared queues when queue arguments don't match #14673
+236
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorbacho
force-pushed
the
shovel-tests
branch
from
9b4e97b to
7f25c52
Compare
If queue arguments don't match, the shovel should still start as for amqp0.9.1 and amqp1.0
dcorbacho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local shovels must start with predeclared queues even if queue arguments don't match, as it is done for amqp0.9.1 and amqp1.0.
Bug detected when adding tests common to all protocols, which predeclare quorum queues. More tests included as they were part of the test refactor in progress.